Differential D14816

[lib] Fetch keys only when a session is missing
ClosedPublic
Actions

Authored by tomek on Jun 6 2025, 12:30 PM.

Tags

None

Referenced Files

None

Subscribers

None

Details

Reviewers

kamil
bartek
ashoat

Commits

rCOMMfbd1ea0c3497: [lib] Fetch keys only when a session is missing

Summary

If a session was missing for any device, we were asking for the keys for all the devices.

https://linear.app/comm/issue/ENG-10753/session-recovery-sometimes-fails

Test Plan

Create a session between device A1 of the user A and the device B1 of the user B. Then add a new secondary device B2 and send a message from A to B. Make sure using some console logs that only keys for B2 were fetched and that only this session was created.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jun 6 2025, 12:30 PM

ashoat published this revision for review.Jun 6 2025, 1:00 PM

ashoat accepted this revision.

This revision is now accepted and ready to land.Jun 6 2025, 1:01 PM

Harbormaster completed remote builds in B34374: Diff 48438.Jun 6 2025, 1:06 PM

Closed by commit rCOMMfbd1ea0c3497: [lib] Fetch keys only when a session is missing. · Explain WhyJun 6 2025, 1:42 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMfbd1ea0c3497: [lib] Fetch keys only when a session is missing.

Revision Contents
Changeset List

Path

Size

lib/

utils/

crypto-utils.js

6 lines

Diff 48439

lib/utils/crypto-utils.js

Loading...