https://linear.app/comm/issue/ENG-10802/svg-images-dont-work
As in linear discussion, since server doesn't transcode svg and tiff images anymore and fixing it would require some work, we just disable them.
Details
Details
Try to send svg, tiff images on web. Verify that you can't select them.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Does this disable it just for images sent in thin threads on web, where (I think) we use sharp on the keyserver for transcoding? Or does it disable it more globally, eg. in thick threads, or in thin threads sent from mobile?
Also curious if we’re using sharp on the keyserver for transcoding at all anymore, given that media is now uploaded to the blob service in all cases (as far as I understand).
Comment Actions
Also curious if we’re using sharp on the keyserver for transcoding at all anymore, given that media is now uploaded to the blob service in all cases (as far as I understand).
We're not. All media are directly uploaded to Blob. The legacy upload_multimedia keyserver endpoint (the one with sharp) is just for old clients.
Comment Actions
Thanks, makes sense. Wonder if we should rename serverCanHandle to canHandle and serverTranscodesImage to canTranscodeImage, since it's not really server-related anymore