Address ENG-10748.
Details
Details
Added a throw in sqlite-data-handler to cause the alert to be shown.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 100 ↗ | (On Diff #48692) | I might be wrong, but I have the impression that in the past, this code was a blocker to removing a larger chunk of deprecated code after we fully launched the signed device list. cc, @tomek who I believe was depreating usingCommServicesAccessToken flag |
| 185–189 ↗ | (On Diff #48692) | I think this is lefotver from the past, might be good to update |
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 100 ↗ | (On Diff #48692) | I thought too that we could entirely remove keyserverRecoveryLogIn but it turns out it still works well in keyserver-connection-handler. As I stated in this comment, the keyserver recovery calls the correct keyserver endpoint, not the deprecated one |
| 185–189 ↗ | (On Diff #48692) | I'll update to Error setting clientDBStore |
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 100 ↗ | (On Diff #48692) | Ok, so it seems we have to keep it |