Paths

Table of Contentst

Differential D15032

[lib][native][web] handle LocalMessageInfo when restoring backup
ClosedPublic
Actions

Authored by kamil on Jul 22 2025, 12:34 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMcc0366cb4f0a: [lib][native][web] handle LocalMessageInfo when restoring backup

Summary

ENG-10884 and ENG-10885.

Context is in the tasks.

Creating one diff because there is a lot of boilerplate, we're doing it many times, so saving some time in splitting this into smaller chunks and reviewing each one separately

Test Plan

Test restore on primary and secondary

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 22 2025, 12:34 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2025, 12:34 PM

kamil edited the summary of this revision. (Show Details)Jul 22 2025, 12:35 PM

Harbormaster completed remote builds in B34686: Diff 48889.Jul 22 2025, 12:53 PM

kamil published this revision for review.Jul 22 2025, 12:55 PM

bartek accepted this revision.Jul 24 2025, 6:38 AM

bartek added inline comments.

lib/reducers/backup-reducer.js
174–181 ↗	(On Diff #48889)	How about de-duplicating this array? We can extract it to a global var and reuse in `user-data-restore-context`
web/shared-worker/worker/shared-worker.js
639 ↗	(On Diff #48889)	To distinguish DB type in case of error

This revision is now accepted and ready to land.Jul 24 2025, 6:38 AM

address review

Harbormaster failed remote builds in B34799: Diff 49004!Jul 24 2025, 2:08 PM

Harbormaster completed remote builds in B34799: Diff 49004.Jul 24 2025, 2:19 PM

Closed by commit rCOMMcc0366cb4f0a: [lib][native][web] handle LocalMessageInfo when restoring backup. · Explain WhyJul 24 2025, 2:26 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcc0366cb4f0a: [lib][native][web] handle LocalMessageInfo when restoring backup.

Revision Contents
Changeset List

Path

Size

lib/

backup/

user-data-restore-context.js

48 lines

components/

secondary-device-qr-auth-context-provider.react.js

1 line

handlers/

restore-backup-handler.react.js

8 lines

reducers/

backup-reducer.js

18 lines

tunnelbroker/

use-peer-to-peer-message-handler.js

2 lines

types/

backup-types.js

10 lines

sqlite-types.js

4 lines

utils/

__mocks__/

1 line

native/

account/

1 line

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

1 line

SQLiteQueryExecutor.h

1 line

SQLiteQueryExecutor.cpp

20 lines

NativeModules/

CommCoreModule.h

4 lines

CommCoreModule.cpp

32 lines

_generated/

commJSI-generated.cpp

database/

1 line

schema/

CommCoreModuleSchema.js

4 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

5 lines

database/

12 lines

shared-worker/

_generated/

comm_query_executor.wasm

types/

sqlite-query-executor.js

2 lines

worker/

shared-worker.js

35 lines

types/

worker-types.js

11 lines

Diff 49006

lib/backup/user-data-restore-context.js

Loading...

lib/components/secondary-device-qr-auth-context-provider.react.js

Loading...

lib/handlers/restore-backup-handler.react.js

Loading...

lib/reducers/backup-reducer.js

Loading...

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...

lib/types/backup-types.js

Loading...

lib/types/sqlite-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/account/restore.js

Loading...

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/database/sqlite-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/database/sqlite-api.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...

web/shared-worker/worker/shared-worker.js

Loading...

web/types/worker-types.js

Loading...