Differential D15168

[lib] Treat no_backup as logged in state
ClosedPublic
Actions

Authored by bartek on Aug 4 2025, 1:50 PM.

Details

Reviewers

kamil

Commits

rCOMM5ef8d5ca4247: [lib] Treat no_backup as logged in state

Summary

Fix ENG-11035

Test Plan

The issue no longer appears. Thankfully, my concerns about flickering were not confirmed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 4 2025, 1:50 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 4 2025, 1:50 PM

Harbormaster failed remote builds in B35044: Diff 49281!Aug 4 2025, 2:05 PM

Rebase

Harbormaster completed remote builds in B35051: Diff 49291.Aug 6 2025, 8:46 AM

bartek published this revision for review.Aug 6 2025, 9:19 AM

bartek edited the test plan for this revision. (Show Details)

kamil accepted this revision.Aug 6 2025, 10:22 AM

This revision is now accepted and ready to land.Aug 6 2025, 10:22 AM

Closed by commit rCOMM5ef8d5ca4247: [lib] Treat no_backup as logged in state. · Explain WhyAug 6 2025, 11:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5ef8d5ca4247: [lib] Treat no_backup as logged in state.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

backup-hooks.js

1 line

Diff 49299

View Options

[lib] Treat no_backup as logged in stateClosedPublicActions