Differential D15240

[native] Avoid keyboard in thread settings screen
ClosedPublic
Actions

Authored by angelika on Aug 27 2025, 2:45 AM.

Details

Reviewers

tomek

Commits

rCOMM6c22eec0260c: [native] Avoid keyboard in thread settings screen

Summary

https://linear.app/comm/issue/ENG-11019/keyboardavoidingview-behavior

Moving KeyboardAvoidingView caused a regression on thread settings screen, the keyboard sometimes covers the screen.

We're using FlatList from react-native-gesture-handler in order to fix another bug (D6417) so just setting renderScrollComponent
won't work. So:

we use FlatList from react-native
which uses scroll view from react-native-keyboard-controller
which uses scroll view from gesture-handler in order to fix the scrolling bug

Video after fixes:

Depends on D15239

Test Plan

Click on description field in thread settings. The field should be scrolled up so that it's not covered by keyboard.
Make sure the screen is scrollable on Android.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Aug 27 2025, 2:45 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 27 2025, 2:45 AM

Harbormaster failed remote builds in B35543: Diff 50024!Aug 27 2025, 2:46 AM

angelika edited the summary of this revision. (Show Details)Aug 27 2025, 3:37 AM

angelika published this revision for review.Aug 27 2025, 3:42 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Aug 28 2025, 8:27 AM

tomek added inline comments.

native/chat/settings/thread-settings.react.js
877–883 ↗	(On Diff #50024)	Let's move it to a function so that the prop doesn't change on each render

This revision now requires changes to proceed.Aug 28 2025, 8:27 AM

Rebase & review changes

Harbormaster failed remote builds in B35686: Diff 50239!Sep 11 2025, 12:18 PM

Fix flow

tomek accepted this revision.Sep 11 2025, 2:27 PM

This revision is now accepted and ready to land.Sep 11 2025, 2:27 PM

Harbormaster failed remote builds in B35692: Diff 50251!Sep 11 2025, 2:39 PM

This revision was landed with ongoing or failed builds.Sep 11 2025, 3:18 PM

Closed by commit rCOMM6c22eec0260c: [native] Avoid keyboard in thread settings screen. · Explain Why

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM6c22eec0260c: [native] Avoid keyboard in thread settings screen.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings.react.js

17 lines

Diff 50257

View Options

native/chat/settings/thread-settings.react.js

[native] Avoid keyboard in thread settings screenClosedPublicActions