Differential D15246

[lib] implement updating thread name and description
ClosedPublic
Actions

Authored by kamil on Aug 27 2025, 12:06 PM.

Details

Reviewers

tomek

Commits

rCOMM2065de0c5a04: [lib] implement updating thread name and description

Summary

ENG-10922.

Depends on D15245

Test Plan

Tested for Farcaster 1:1, Farcaster group when being an admin, Farcaster group without being an admin, tested robotext message

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 27 2025, 12:06 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2025, 12:06 PM

kamil added a child revision: D15247: [lib][web][native] disable background notifs for Farcaster threads.Aug 27 2025, 12:07 PM

Harbormaster failed remote builds in B35549: Diff 50030!Aug 27 2025, 12:17 PM

kamil published this revision for review.Aug 27 2025, 12:25 PM

kamil added inline comments.Aug 27 2025, 12:28 PM

lib/shared/threads/protocols/farcaster-thread-protocol.js
145–150 ↗	(On Diff #50030)	ENG-11176 ENG-10929

kamil edited the test plan for this revision. (Show Details)Aug 27 2025, 12:29 PM

tomek accepted this revision.Aug 28 2025, 9:59 AM

This revision is now accepted and ready to land.Aug 28 2025, 9:59 AM

rebase

Harbormaster failed remote builds in B35572: Diff 50065!Aug 28 2025, 11:43 AM

This revision was landed with ongoing or failed builds.Aug 28 2025, 12:03 PM

Closed by commit rCOMM2065de0c5a04: [lib] implement updating thread name and description. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2065de0c5a04: [lib] implement updating thread name and description.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-hooks.js

21 lines

shared/

farcaster/

farcaster-api.js

24 lines

threads/

protocols/

farcaster-thread-protocol.js

83 lines

thread-spec.js

8 lines

utils/

convert-farcaster-message-to-comm-messages.js

15 lines

Diff 50071

View Options

lib/hooks/thread-hooks.js

View Options

lib/shared/farcaster/farcaster-api.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

View Options

lib/utils/convert-farcaster-message-to-comm-messages.js

[lib] implement updating thread name and descriptionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50071

lib/hooks/thread-hooks.js

lib/shared/farcaster/farcaster-api.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/thread-spec.js

lib/utils/convert-farcaster-message-to-comm-messages.js

[lib] implement updating thread name and description
ClosedPublic
Actions

Revision Contents
Changeset List