Differential D15266

[lib] refactor `useDMActivityHandler` to use protocols
ClosedPublic
Actions

Authored by kamil on Aug 29 2025, 11:16 AM.

Details

Reviewers

tomek

Commits

rCOMMd057b98e6e65: [lib] refactor `useDMActivityHandler` to use protocols

Summary

ENG-11183

This was code duplication, which is bad, but it also allows to reuse this handler for Farcaster threads

Depends on D15265

Test Plan

Test unreads for DMs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2025, 11:16 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 29 2025, 11:16 AM

kamil edited the summary of this revision. (Show Details)Aug 29 2025, 11:16 AM

kamil added a parent revision: D15265: [native] fix unread statuses for DMs.

Harbormaster failed remote builds in B35582: Diff 50086!Aug 29 2025, 11:17 AM

kamil added a child revision: D15267: [lib][web][native] rename `DMActivityHandler` to `NonKeyserverActivityHandler`.Aug 29 2025, 11:17 AM

kamil published this revision for review.Aug 29 2025, 11:57 AM

tomek accepted this revision.Sep 1 2025, 8:22 AM

This revision is now accepted and ready to land.Sep 1 2025, 8:22 AM

This revision was landed with ongoing or failed builds.Sep 1 2025, 11:03 AM

Closed by commit rCOMMd057b98e6e65: [lib] refactor `useDMActivityHandler` to use protocols. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd057b98e6e65: [lib] refactor `useDMActivityHandler` to use protocols.

Revision Contents
Changeset List

Path

Size

lib/

actions/

activity-actions.js

7 lines

handlers/

dm-activity-handler.js

86 lines

Diff 50105

View Options

lib/actions/activity-actions.js