Differential D15330

[keyserver] Use `renderToPipeableStream`
ClosedPublic
Actions

Authored by tomek on Sep 12 2025, 10:49 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
bartek
ashoat

Commits

rCOMM86c7aea29099: [keyserver] Use `renderToPipeableStream`

Summary

Use the new API

https://linear.app/comm/issue/ENG-2512/replace-deprecated-rendertonodestream-api

Test Plan

Run keyserver and web, open the web app and check if it loads correctly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 12 2025, 10:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2025, 10:49 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2025, 10:55 AM

Harbormaster failed remote builds in B35695: Diff 50258!

tomek requested review of this revision.Sep 12 2025, 10:55 AM

ashoat accepted this revision.Sep 12 2025, 12:09 PM

This revision is now accepted and ready to land.Sep 12 2025, 12:09 PM

bartek accepted this revision.Sep 12 2025, 12:23 PM

bartek added inline comments.

keyserver/src/responders/landing-handler.js
272 ↗	(On Diff #50258)	same as below
keyserver/src/responders/website-responders.js
205 ↗	(On Diff #50258)	We don't need this console.log - it was only for debugging
215–216 ↗	(On Diff #50258)	leftover, not needed

Fix eslint and clean up

Harbormaster failed remote builds in B35696: Diff 50259!Sep 12 2025, 12:36 PM

This revision was landed with ongoing or failed builds.Sep 12 2025, 2:11 PM

Closed by commit rCOMM86c7aea29099: [keyserver] Use `renderToPipeableStream`. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM86c7aea29099: [keyserver] Use `renderToPipeableStream`.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

landing-handler.js

82 lines

website-responders.js

66 lines

15 lines

Diff 50260

keyserver/src/responders/landing-handler.js

Loading...

keyserver/src/responders/website-responders.js

Loading...

yarn.lock

Loading...