[nix] Update Nix
ClosedPublic
Actions

Authored by ashoat on Sep 16 2025, 5:55 PM.

Details

Reviewers

tomek
bartek

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM9173c36e48ca: [nix] Update Nix

Summary

Necessary to fix Terraform on macOS 26 (ENG-11268).

This part of the commit was automated from the flake.lock update (nix flake update nixpkgs --commit-lock-file):

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/d879125d61a0be8ecb2afddaca8f2b0530db0260?narHash=sha256-zLvAJ%2BXTI7gIlUqlrKj8j4%2BPOZXDB6kUOnV0yBvSIMc%3D' (2022-12-29)
  → 'github:nixos/nixpkgs/0d7c15863b251a7a50265e57c1dca1a7add2e291?narHash=sha256-/aA9A/OBmnuOMgwfzdsXRusqzUpd8rQnQY8jtrHK%2BTo%3D' (2025-09-15)

Other than the flake.lock update, the rest was performed manually. I'll explain inline.

Test Plan

nix develop

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 16 2025, 5:55 PM

Owners added a reviewer: Restricted Owners Package.Sep 16 2025, 5:55 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2025, 5:57 PM

Harbormaster failed remote builds in B35756: Diff 50348!

Fixes

ashoat edited the summary of this revision. (Show Details)Sep 16 2025, 6:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2025, 7:00 PM

Harbormaster failed remote builds in B35757: Diff 50349!

ashoat requested review of this revision.Sep 16 2025, 7:01 PM

ashoat added inline comments.

flake.nix
8 ↗	(On Diff #50349)	Removed this since I was able to update it and addressed the `arcanist+php8.0` issue
35–37 ↗	(On Diff #50349)	This was necessary to add due to the notice documented in ENG-11269
43 ↗	(On Diff #50349)	`nixpkgs-unstable` no longer hosts PHP 8.0, so we have to use at least PHP 8.1
nix/arcanist-php81-fix.patch
19 ↗	(On Diff #50349)	This patch addresses a new error from PHP 8.1 due to the possibility of `null` being passed in to `strlen`
nix/arcanist.nix
14–21 ↗	(On Diff #50349)	I updated to the latest commit in the Arcanist repo since it has some fixes for newer PHP versions
nix/dev-shell.nix
21 ↗	(On Diff #50349)	This was necessary to address an error I was seeing when running `nix develop`: error: tool 'git' not found
114–121 ↗	(On Diff #50349)	These were removed to address this error: error: darwin.apple_sdk_11_0 has been removed as it was a legacy compatibility stub; see <https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks> for migration instructions

Buildkite CI jobs that rely on Nix (Emscripten, Farcaster signer) are expected to fail, since we run the Buildkite agent inside of Nix. After landing this I'll need to kill the Buildkite agent, exit the Nix environment, update the repo, and then re-run nix develop and the Buildkite agent. Improving this is tracked in ENG-6439.

ashoat added a child revision: D15358: [terraform] Update config for Terraform 1.13.Sep 16 2025, 7:14 PM

bartek accepted this revision as: bartek.Sep 16 2025, 7:18 PM

This revision is now accepted and ready to land.Sep 16 2025, 7:18 PM

This revision was landed with ongoing or failed builds.Sep 16 2025, 9:08 PM

Closed by commit rCOMM9173c36e48ca: [nix] Update Nix. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9173c36e48ca: [nix] Update Nix.