By the way of working on notifs, I ran cargo clippy for the whole workspace and fixed most easily fixable errors. Most of them were auto-applicable suggestions.
Depends on D15373
Details
Details
- Reviewers
tomek - Commits
- rCOMMc265ecddc20e: Fix clippy warnings
cargo built all packages in workspace
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/commtest/src/identity/device.rs | ||
|---|---|---|
| 100 ↗ | (On Diff #50409) | Redundant no-op conversion |
| services/identity/src/database.rs | ||
| 1046 ↗ | (On Diff #50409) | This was introduced in recent versions of Rust and is very handy. Now Clippy suggests using it too |
| services/identity/src/database/device_list.rs | ||
| 1–2 ↗ | (On Diff #50409) | This is for functions returning Result<_, SomeError>, where SomeError is a large enum, e.g., containing AWS errors that are typically big. Ultimately, we should wrap these enum variants with Box but this is large refactoring because it breaks auto-conversions. |
| shared/comm-lib/src/database.rs | ||
| 706–709 ↗ | (On Diff #50409) | as_bytes() is redundant because string.len() by default returns byte length |
| shared/comm-opaque2/src/server/login.rs | ||
| 14 ↗ | (On Diff #50409) | This is redundant. serde #[default] on types implementing Default automatically resolves to ThatType::default |