Details

Reviewers

ashoat
bartek

Commits

rCOMM956f8b65eb4e: [web][native] Display Farcaster icon in user profile

Summary

ENG-11218.
Added icon next to Farcaster username

Test Plan

web	native

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 19 2025, 4:37 PM

bartek held this revision as a draft.

Harbormaster failed remote builds in B35804: Diff 50429!Sep 19 2025, 4:38 PM

bartek edited the test plan for this revision. (Show Details)Sep 19 2025, 4:51 PM

bartek attached a referenced file: F13761662: Simulator Screenshot - iPhone 16 Pro - 2025-09-19 at 18.50.56.png. (Show Details)

bartek attached a referenced file: F13761476: Screenshot 2025-09-19 at 18.35.14.png. (Show Details)

Fix margin

Harbormaster failed remote builds in B35805: Diff 50430!Sep 19 2025, 4:57 PM

I won't be able to land this one, feel free to commandeer this diff, and restart CI once it's fixed

Fix CSS style typings

Harbormaster failed remote builds in B35808: Diff 50434!Sep 19 2025, 8:05 PM

tomek commandeered this revision.Sep 22 2025, 9:58 AM

tomek edited reviewers, added: bartek; removed: tomek.

ashoat accepted this revision.Sep 22 2025, 2:36 PM

ashoat added inline comments.

native/components/protocol-icon.react.js
50	Unclear why this is needed, but we could use `StyleSheet.flatten` if it really is (I would just remove it)

This revision is now accepted and ready to land.Sep 22 2025, 2:36 PM

tomek added inline comments.Sep 25 2025, 10:55 AM

native/components/protocol-icon.react.js
50	Removed the `flat()` call and it still looks correct on native

Remove unnecessary call

This revision was landed with ongoing or failed builds.Sep 25 2025, 1:07 PM

Closed by commit rCOMM956f8b65eb4e: [web][native] Display Farcaster icon in user profile. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM956f8b65eb4e: [web][native] Display Farcaster icon in user profile.

[web][native] Display Farcaster icon in user profile
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50434

native/components/protocol-icon.react.js

native/user-profile/user-profile.react.js

web/components/protocol-icon.react.js

web/modals/user-profile/user-profile.css

web/modals/user-profile/user-profile.react.js

[web][native] Display Farcaster icon in user profileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50434

native/components/protocol-icon.react.js

native/user-profile/user-profile.react.js

web/components/protocol-icon.react.js

web/modals/user-profile/user-profile.css

web/modals/user-profile/user-profile.react.js

[web][native] Display Farcaster icon in user profile
ClosedPublic
Actions

Revision Contents
Changeset List