Details
Careful code inspection and Flow
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/components/farcaster-data-handler.react.js | ||
|---|---|---|
| 178–179 ↗ | (On Diff #50461) | This is logically identical to the previous logic |
| 185 ↗ | (On Diff #50461) | I think this simplification captures our intention a lot better. We want to set the local FID if it no longer matches identity's value, as long as the identity request didn't time out |
| 191 ↗ | (On Diff #50461) | This return is risk because we end before calling setFIDLoaded. It was initially here because we were unlinking the FID, and I think we wanted to re-run the effect before considering the FID set. Perhaps after D13738 we should have removed the return |
| native/components/connect-farcaster-bottom-sheet.react.js | ||
| 84–90 ↗ | (On Diff #50461) | This is logically identical to the previous logic |
| 91 ↗ | (On Diff #50461) | There is no reason to check supportsFarcasterDCs (it is guaranteed to be true here) and no reason to check showConnectDCs (setting a React state to the same value is a no-op, and won't lead to a re-render) |