[native] Fix creating community subchannels
ClosedPublic
Actions

Authored by tomek on Sep 29 2025, 12:48 PM.

Details

Reviewers

kamil
ashoat

Commits

rCOMM0e85c6beb162: [native] Fix creating community subchannels

Summary

There was a render loop due to a property changing on every render

https://linear.app/comm/issue/ENG-11329/its-not-possible-to-create-a-new-thread-within-a-community

Test Plan

Check if creating a subchannel works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 29 2025, 12:48 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 29 2025, 12:49 PM

Delete unrelated change

tomek published this revision for review.Sep 29 2025, 2:12 PM

Classic! It probably wouldn't be very hard to start enabling React Compiler for at least some of our codebase

This revision is now accepted and ready to land.Sep 29 2025, 2:21 PM

In D15391#423692, @ashoat wrote:

Classic! It probably wouldn't be very hard to start enabling React Compiler for at least some of our codebase

Yeah, created https://linear.app/comm/issue/ENG-11334/consider-starting-using-react-compiler to track

This revision was landed with ongoing or failed builds.Sep 29 2025, 3:33 PM

Closed by commit rCOMM0e85c6beb162: [native] Fix creating community subchannels. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM0e85c6beb162: [native] Fix creating community subchannels.

Revision Contents
Changeset List

Path

Size

native/

chat/

compose-subchannel.react.js

6 lines

Diff 50472

View Options

native/chat/compose-subchannel.react.js

[native] Fix creating community subchannelsClosedPublicActions