[lib] Remove invariant on media_infos in rawMessageInfoFromClientDB
ClosedPublic
Actions

Authored by ashoat on Sep 29 2025, 2:27 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM04206a8ebf7f: [lib] Remove invariant on media_infos in rawMessageInfoFromClientDB

Summary

This invariant can lead to ENG-11326 and ENG-9079.

The code below can already handle the case where it is not set. While it's true that we should eventually investigate what is causing this, for now it's better to avoid crashing the app.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/crash

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 29 2025, 2:27 PM

ashoat published this revision for review.Sep 29 2025, 2:28 PM

tomek accepted this revision.Sep 29 2025, 3:34 PM

This revision is now accepted and ready to land.Sep 29 2025, 3:34 PM

This revision was landed with ongoing or failed builds.Sep 29 2025, 4:58 PM

Closed by commit rCOMM04206a8ebf7f: [lib] Remove invariant on media_infos in rawMessageInfoFromClientDB. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM04206a8ebf7f: [lib] Remove invariant on media_infos in rawMessageInfoFromClientDB.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

multimedia-message-spec.js

5 lines

Diff 50470

View Options

lib/shared/messages/multimedia-message-spec.js

[lib] Remove invariant on media_infos in rawMessageInfoFromClientDBClosedPublicActions