[lib] Create a lightweight sync util
ClosedPublic
Actions

Authored by tomek on Oct 2 2025, 11:36 AM.

Details

Reviewers

kamil

Commits

rCOMMd89db8ccb17e: [lib] Create a lightweight sync util

Summary

This sync hook is a lot cheaper to run - it updates threads based on a result from fetching the inbox and fetches the conversations only when necessary.

https://linear.app/comm/issue/ENG-11209/only-refresh-farcaster-threads-that-are-visible-on-screen

Test Plan

Tested with the rest of the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 2 2025, 11:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 2 2025, 11:36 AM

tomek added a child revision: D15408: [lib] Run the lightweight sync.Oct 2 2025, 11:41 AM

Harbormaster completed remote builds in B35852: Diff 50501.Oct 2 2025, 11:53 AM

tomek requested review of this revision.Oct 2 2025, 11:53 AM

tomek added inline comments.Oct 2 2025, 12:59 PM

lib/utils/create-farcaster-raw-thread-info.js
335	There's a regression here - the refresh drops the admin role of the current user

Use FID instead of Comm ID

Harbormaster completed remote builds in B35856: Diff 50505.Oct 2 2025, 1:48 PM

Nice

lib/shared/farcaster/farcaster-hooks.js
741 ↗	(On Diff #50505)	What is the point of `Promise.all`?
750–756 ↗	(On Diff #50505)	This can be done using only one iteration
lib/utils/create-farcaster-raw-thread-info.js
326–328 ↗	(On Diff #50505)	I would change conditions ordere here

This revision is now accepted and ready to land.Oct 3 2025, 11:44 AM

Address the review

lib/shared/farcaster/farcaster-hooks.js
741 ↗	(On Diff #50505)	It is added for symmetry to the regular sync. The regular sync uses it as a preparation for request and archived conversations fetching. In D15416 we're fetching all three categories.