[native] Fix ThumbhashModule.kt for Android 8
ClosedPublic
Actions

Authored by ashoat on Oct 2 2025, 10:59 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM8e4650287aab: [native] Fix ThumbhashModule.kt for Android 8

Summary

private val decoderListener is accessing ImageDecoder outside of a version guard conditional.

Test Plan

Send an image on both Android 8 (emulator) and latest Android (physical device) and confirm that thumbhash is generated correctly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 2 2025, 10:59 PM

ashoat added a child revision: D15415: [native] Fix Android XML to work with Android 8.

Harbormaster completed remote builds in B35863: Diff 50517.Oct 2 2025, 11:18 PM

ashoat requested review of this revision.Oct 2 2025, 11:18 PM

Landing without review as it's been reviewed by AI, tested, and I want to get a release with the fix out quickly

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2025, 11:34 PM

Closed by commit rCOMM8e4650287aab: [native] Fix ThumbhashModule.kt for Android 8. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8e4650287aab: [native] Fix ThumbhashModule.kt for Android 8.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

android/

src/

main/

java/

app/

comm/

android/

thumbhash/

ThumbhashModule.kt

13 lines

Diff 50517

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

[native] Fix ThumbhashModule.kt for Android 8ClosedPublicActions