Differential D15418

[lib] Handle joining threads
ClosedPublic
Actions

Authored by tomek on Oct 3 2025, 3:12 PM.

Details

Reviewers

kamil

Commits

rCOMM8e82c40b2846: [lib] Handle joining threads

Summary

Call the API and fetch an updated thread with all the messages.

https://linear.app/comm/issue/ENG-10938/farcaster-join-thread

Depends on D15416

Test Plan

Join a request on Comm and check if both on Comm and on Farcaster the thread is joined.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 3 2025, 3:12 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 3 2025, 3:12 PM

tomek edited the summary of this revision. (Show Details)Oct 3 2025, 3:13 PM

tomek added a parent revision: D15416: [lib] Display request and archived threads.

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 3 2025, 4:06 PM

Harbormaster failed remote builds in B35867: Diff 50523!

tomek requested review of this revision.Oct 3 2025, 4:24 PM

Harbormaster completed remote builds in B35867: Diff 50523.Oct 3 2025, 5:05 PM

kamil accepted this revision.Oct 6 2025, 9:49 AM

This revision is now accepted and ready to land.Oct 6 2025, 9:49 AM

Closed by commit rCOMM8e82c40b2846: [lib] Handle joining threads. · Explain WhyOct 6 2025, 9:57 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM8e82c40b2846: [lib] Handle joining threads.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-hooks.js

14 lines

shared/

farcaster/

farcaster-api.js

20 lines

threads/

protocols/

farcaster-thread-protocol.js

22 lines

thread-spec.js

3 lines

Diff 50537

View Options

lib/hooks/thread-hooks.js

View Options

lib/shared/farcaster/farcaster-api.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

[lib] Handle joining threadsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50537

lib/hooks/thread-hooks.js

lib/shared/farcaster/farcaster-api.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/thread-spec.js

[lib] Handle joining threads
ClosedPublic
Actions

Revision Contents
Changeset List