Show Farcaster in the ancestry and visibility sections. Also figured out that maybe updating the DMs is a good idea.
Details
Details
Check if Farcaster and DM thread settings look ok.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 961 ↗ | (On Diff #50533) | Shouldn't this match threadAncestorLabel and be Farcaster DC? If yes, can we just use threadAncestorLabel? |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 961 ↗ | (On Diff #50533) | Not sure. I think DC makes it a bit too wordy... Regardless, threadAncestorLabel is a bit hacky for this purpose, because it is a function, so it's not that easy to be reused here - for the keyserver threads, the behavior is a bit different. Maybe they can be unified, but it isn't trivial. |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 961 ↗ | (On Diff #50533) | Makes sense, let's leave it as it is, thanks for explaining |