Paths

Table of Contentst

Differential D15422

[lib] Keep the unsupported Farcaster messages
ClosedPublic
Actions

Authored by tomek on Oct 6 2025, 12:57 PM.

Details

Reviewers

kamil

Commits

rCOMM1fe7adf17f73: [lib] Keep the unsupported Farcaster messages

Summary

Keep the message and don't display them in a list and in a preview

https://linear.app/comm/issue/ENG-11367/keep-the-unsupported-messages-in-the-db

Test Plan

Check if the pin_message messages are there using console logs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 6 2025, 12:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 6 2025, 12:57 PM

Update the ID

Harbormaster completed remote builds in B35874: Diff 50541.Oct 6 2025, 1:21 PM

Harbormaster completed remote builds in B35875: Diff 50542.

tomek requested review of this revision.Oct 6 2025, 1:21 PM

kamil accepted this revision.Oct 7 2025, 11:37 AM

This revision is now accepted and ready to land.Oct 7 2025, 11:37 AM

Closed by commit rCOMM1fe7adf17f73: [lib] Keep the unsupported Farcaster messages. · Explain WhyOct 7 2025, 2:20 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1fe7adf17f73: [lib] Keep the unsupported Farcaster messages.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

4 lines

shared/

farcaster/

farcaster-hooks.js

7 lines

messages/

message-specs.js

2 lines

plain-message-spec.js

75 lines

unsupported-message-spec.js

3 lines

unshim-utils.js

5 lines

types/

message-types-enum.js

4 lines

messages/

plain.js

35 lines

unsupported.js

9 lines

utils/

convert-farcaster-message-to-comm-messages.js

26 lines

native/

cpp/

CommonCpp/

NativeModules/

PersistentStorageUtilities/

MessageOperationsUtilities/

MessageSpecs.h

3 lines

MessageSpecs/

PlainMessageSpec.h

14 lines

MessageTypeEnum.h

1 line

ios/

Comm.xcodeproj/

project.pbxproj

2 lines

Diff 50548

View Options

lib/selectors/chat-selectors.js

View Options

lib/shared/farcaster/farcaster-hooks.js

View Options

lib/shared/messages/message-specs.js

View Options

lib/shared/messages/plain-message-spec.js

View Options

lib/shared/messages/unsupported-message-spec.js

View Options

lib/shared/unshim-utils.js

View Options

lib/types/message-types-enum.js

View Options

lib/types/messages/plain.js

View Options

lib/types/messages/unsupported.js

View Options

lib/utils/convert-farcaster-message-to-comm-messages.js

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/PlainMessageSpec.h

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h

View Options

native/ios/Comm.xcodeproj/project.pbxproj

[lib] Keep the unsupported Farcaster messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50548

lib/selectors/chat-selectors.js

lib/shared/farcaster/farcaster-hooks.js

lib/shared/messages/message-specs.js

lib/shared/messages/plain-message-spec.js

lib/shared/messages/unsupported-message-spec.js

lib/shared/unshim-utils.js

lib/types/message-types-enum.js

lib/types/messages/plain.js

lib/types/messages/unsupported.js

lib/utils/convert-farcaster-message-to-comm-messages.js

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/PlainMessageSpec.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h

native/ios/Comm.xcodeproj/project.pbxproj

[lib] Keep the unsupported Farcaster messages
ClosedPublic
Actions

Revision Contents
Changeset List