Differential D15443

[lib] Don't count background threads when updating badge count
ClosedPublic
Actions

Authored by tomek on Oct 10 2025, 9:46 AM.

Tags

None

Referenced Files

	F32156483: D15443.1765035941.diff
	Fri, Dec 5, 3:45 PM

	F32122993: D15443.1765022046.diff
	Fri, Dec 5, 11:54 AM

	F32060930: D15443.1764993840.diff
	Fri, Dec 5, 4:04 AM

Subscribers

Details

Reviewers

Commits

rCOMMe29b185dcbbc: [lib] Don't count background threads when updating badge count

Summary

We should only count the threads from the home tab.

https://linear.app/comm/issue/ENG-11402/ios-unread-badge-shows-21-unread-after-receiving-a-notif

Test Plan

Run the app and check if the badge count doesn't include background threads.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 10 2025, 9:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 10 2025, 9:46 AM

Harbormaster completed remote builds in B35908: Diff 50596.Oct 10 2025, 10:05 AM

tomek requested review of this revision.Oct 10 2025, 10:05 AM

kamil added a child revision: D15446: [web] fix badge handler for web.Oct 10 2025, 10:10 AM

kamil accepted this revision.Oct 10 2025, 10:10 AM

This revision is now accepted and ready to land.Oct 10 2025, 10:10 AM

Closed by commit rCOMMe29b185dcbbc: [lib] Don't count background threads when updating badge count. · Explain WhyOct 10 2025, 10:15 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe29b185dcbbc: [lib] Don't count background threads when updating badge count.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

thread-selectors.js

8 lines

Diff 50600

lib/selectors/thread-selectors.js

Loading...