Differential D15463

[lib] Remove unnecessary Farcaster props
ClosedPublic
Actions

Authored by tomek on Oct 14 2025, 11:52 AM.

Details

Reviewers

kamil

Commits

rCOMM98fe895b13e8: [lib] Remove unnecessary Farcaster props

Summary

There's no point in validating the props that we aren't using. Kept the ones required for pinning and deleting.

https://linear.app/comm/issue/ENG-11106/remove-unecesary-props-from-farcaster-validators

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 14 2025, 11:52 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 14 2025, 11:52 AM

tomek published this revision for review.Oct 14 2025, 12:23 PM

kamil accepted this revision.Oct 14 2025, 12:31 PM

This revision is now accepted and ready to land.Oct 14 2025, 12:31 PM

This revision was landed with ongoing or failed builds.Oct 14 2025, 12:54 PM

Closed by commit rCOMM98fe895b13e8: [lib] Remove unnecessary Farcaster props. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM98fe895b13e8: [lib] Remove unnecessary Farcaster props.

tomek added a reverting change: D15512: Revert "[lib] Remove unnecessary Farcaster props".Oct 23 2025, 10:30 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

farcaster/

farcaster-conversation-types.js

63 lines

farcaster-messages-types.js

37 lines

Diff 50637

View Options

lib/shared/farcaster/farcaster-conversation-types.js