Display the number of messages
https://linear.app/comm/issue/ENG-11456/add-more-details-in-farcaster-sync-progress-information
Details
Details
- Reviewers
kamil - Commits
- rCOMM267b769ce9b5: [lib] Report number of messages during sync
Sync and check if the data is shown.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 175–186 ↗ | (On Diff #50657) | We're getting the count just once, so there's no point in maintaining the count through the inserts. |
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 347 ↗ | (On Diff #50657) | It looks like we could remove this line |
| 1438–1440 ↗ | (On Diff #50657) | We should avoid allowing the caller to mutate our internal React state |
| native/farcaster/farcaster-sync-loading-screen.react.js | ||
| 73 ↗ | (On Diff #50657) | Why not include the information about conversations here too? |
| native/farcaster/farcaster-sync-loading-screen.react.js | ||
|---|---|---|
| 73 ↗ | (On Diff #50657) | On web we were displaying the number because the loading state doesn't show the percentage progress. On native, there's the percentage progress - but agree, displaying the number of both platforms makes sense! |