Update the count in each batch
https://linear.app/comm/issue/ENG-11456/add-more-details-in-farcaster-sync-progress-information
Details
Details
Sync and check if the data is shown.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 806–808 | This is a bugfix | |
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 767 | This is the API limit | |
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 179 | Depending on what the apply means in this context. When we fetch a new conversation, we're fetching all the messages from it. Then, some of the messages are put into the JOIN_THREAD update. So if we're counting the messages during fetching (version from this diff) we don't care about the updates, because they are created based on the fetch result, later in the process. In the previous version, we were counting the messages after all the fetching was done, and the updates were created, so we had to get the counts from them. | |
| 806–808 | Replied in the issue, but I don't think it is a good explanation. | |