Paths

Table of Contentst

[lib] Enable setting all thread avatar types except emoji for Farcaster
ClosedPublic
Actions

Authored by tomek on Oct 30 2025, 3:38 PM.

Details

Reviewers

kamil
ashoat

Commits

rCOMMe13cfa65a73a: [lib] Enable setting all thread avatar types except emoji for Farcaster

Summary

Enable setting the avatars for Farcaster. Remove the emoji option.

https://linear.app/comm/issue/ENG-11176/implement-updating-thread-avatar

Test Plan

Tested with the rest of the stack - check if the displayed options are correct on both platforms.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 30 2025, 3:38 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 30 2025, 3:38 PM

tomek added a child revision: D15531: [lib] Introduce the API that allows setting the avatar.Oct 30 2025, 3:39 PM

Harbormaster completed remote builds in B36035: Diff 50807.Oct 30 2025, 4:06 PM

tomek requested review of this revision.Oct 30 2025, 4:06 PM

ashoat accepted this revision.Oct 30 2025, 11:21 PM

ashoat added inline comments.

lib/shared/threads/protocols/farcaster-thread-protocol.js
1120	Why is this still here? Should `temporarilyDisabledFeatures` be removed entirely?

This revision is now accepted and ready to land.Oct 30 2025, 11:21 PM

tomek added inline comments.Oct 31 2025, 8:38 AM

lib/shared/threads/protocols/farcaster-thread-protocol.js
1120	Right, created D15535 to remove

Closed by commit rCOMMe13cfa65a73a: [lib] Enable setting all thread avatar types except emoji for Farcaster. · Explain WhyOct 31 2025, 8:44 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe13cfa65a73a: [lib] Enable setting all thread avatar types except emoji for Farcaster.

Revision Contents
Changeset List

Path

Size

lib/

shared/

threads/

protocols/

dm-thread-protocol.js

1 line

farcaster-thread-protocol.js

2 lines

keyserver-thread-protocol.js

1 line

thread-spec.js

2 lines

native/

avatars/

avatar-hooks.js

2 lines

edit-thread-avatar.react.js

34 lines

web/

avatars/

edit-thread-avatar-menu.react.js

7 lines

edit-thread-avatar.react.js

5 lines

Diff 50807

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

View Options

native/avatars/avatar-hooks.js

View Options

native/avatars/edit-thread-avatar.react.js

View Options

web/avatars/edit-thread-avatar-menu.react.js

View Options

web/avatars/edit-thread-avatar.react.js

[lib] Enable setting all thread avatar types except emoji for FarcasterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50807

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/thread-spec.js

native/avatars/avatar-hooks.js

native/avatars/edit-thread-avatar.react.js

web/avatars/edit-thread-avatar-menu.react.js

web/avatars/edit-thread-avatar.react.js

[lib] Enable setting all thread avatar types except emoji for Farcaster
ClosedPublic
Actions

Revision Contents
Changeset List