Page MenuHomePhabricator
Differential D3104

[server] Wrap `server.js` loop async
AbandonedPublic
Actions

Authored by • anand on Feb 3 2022, 8:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 1:04 AM
Unknown Object (File)
Fri, Nov 8, 10:39 PM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 9:53 PM
Unknown Object (File)
Oct 26 2024, 7:30 PM
Unknown Object (File)
Oct 7 2024, 8:48 AM
Unknown Object (File)
Oct 7 2024, 8:47 AM
Unknown Object (File)
Oct 7 2024, 7:54 AM
View All 89 Files
Subscribers
• adrian
ashoat
• benschac
• karol
tomek

Details

Reviewers
atul
ashoat
Summary

Splitting D2722 into two diffs. This diff wraps server.js in an async function to prevent workers from spawning prior to completion of migrations.

Test Plan

Went through test cases detailed in D2628. (Test migrations on server instantiation.)

Diff Detail

Repository
rCOMM Comm
Branch
firststack
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• anand created this revision.Feb 3 2022, 8:01 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 3 2022, 8:01 PM
Harbormaster completed remote builds in B6538: Diff 9276.Feb 3 2022, 8:06 PM
• anand requested review of this revision.Feb 3 2022, 8:06 PM
ashoat requested changes to this revision.Feb 3 2022, 8:32 PM

You're doing something super confusing here. This diff overlaps with D2722. That should never happen... you should be stacking one on top of the other

Anyways, see my feedback in D2722. You should probably abandon this diff

This revision now requires changes to proceed.Feb 3 2022, 8:32 PM
Herald added a subscriber: • benschac. · View Herald TranscriptFeb 3 2022, 8:32 PM
• anand abandoned this revision.Feb 3 2022, 9:09 PM

Revision Contents
Changeset List

PathSize
server/
src/
160 lines

Diff 9276

View Options

server/src/server.js

Loading...