Page MenuHomePhabricator
Differential D3140

[web] [theme] you need permission, update theme, center content
ClosedPublic
Actions

Authored by • benschac on Feb 8 2022, 11:28 AM.
Tags
None
Referenced Files
F3407023: D3140.id9526.diff
Wed, Dec 4, 3:51 AM
F3407022: D3140.id9415.diff
Wed, Dec 4, 3:51 AM
F3407021: D3140.id9525.diff
Wed, Dec 4, 3:51 AM
F3407020: D3140.id9409.diff
Wed, Dec 4, 3:51 AM
F3407019: D3140.id9413.diff
Wed, Dec 4, 3:51 AM
F3407018: D3140.id9414.diff
Wed, Dec 4, 3:51 AM
F3407017: D3140.id9524.diff
Wed, Dec 4, 3:51 AM
F3407016: D3140.id.diff
Wed, Dec 4, 3:50 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMae0985dee4bc: [web] [theme] you need permission, update theme, center content
Summary

before:

Image 2022-02-08 at 2.22.59 PM.jpg (476×2 px, 52 KB)

after:

Image 2022-02-08 at 2.26.43 PM.jpg (1×2 px, 136 KB)

Test Plan

make sure it looks okay

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 8 2022, 11:28 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 8 2022, 11:28 AM
• benschac edited the summary of this revision. (Show Details)Feb 8 2022, 11:31 AM
Harbormaster completed remote builds in B6645: Diff 9409.Feb 8 2022, 11:34 AM
• benschac requested review of this revision.Feb 8 2022, 11:34 AM
atul requested changes to this revision.Feb 8 2022, 11:58 AM

Looks like a merge conflict snuck into this diff, feel free to re-request review once it's fixed up!

web/chat/chat-input-bar.css
52–56 ↗(On Diff #9409)

Ah, looks like there are some merge conflicts here

This revision now requires changes to proceed.Feb 8 2022, 11:58 AM
• benschac updated this revision to Diff 9413.Feb 8 2022, 12:14 PM

remove rebase conflict

atul added inline comments.Feb 8 2022, 12:16 PM
web/chat/chat-input-bar.css
52–55 ↗(On Diff #9413)

Hm, I think there still might be an issue?

The difference between this diff (9413) and the previous (9409) should have this in red as being excluded. But the difference between this diff (9413) and the base should not have this appearing in red.

• benschac added inline comments.Feb 8 2022, 12:17 PM
web/chat/chat-input-bar.css
52–56 ↗(On Diff #9409)

oh damn. Not sure how I missed this in self review. Sorry about that.

• benschac planned changes to this revision.Feb 8 2022, 12:17 PM
• benschac added inline comments.
web/chat/chat-input-bar.css
52–55 ↗(On Diff #9413)

yes yes, was just looking into that now.

Harbormaster completed remote builds in B6648: Diff 9413.Feb 8 2022, 12:19 PM
• benschac updated this revision to Diff 9414.Feb 8 2022, 12:30 PM

fix merge conflict

• benschac updated this revision to Diff 9415.Feb 8 2022, 12:31 PM

add line

Harbormaster completed remote builds in B6649: Diff 9414.Feb 8 2022, 12:35 PM
Harbormaster completed remote builds in B6650: Diff 9415.
ashoat accepted this revision.Feb 8 2022, 9:38 PM
• benschac updated this revision to Diff 9524.Feb 10 2022, 6:40 AM

rebase

• benschac updated this revision to Diff 9525.Feb 10 2022, 6:43 AM

remove rebased theme variables

This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2022, 6:44 AM
This revision was landed with ongoing or failed builds.
Closed by commit rCOMMae0985dee4bc: [web] [theme] you need permission, update theme, center content (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMae0985dee4bc: [web] [theme] you need permission, update theme, center content.
Harbormaster completed remote builds in B6713: Diff 9524.Feb 10 2022, 6:45 AM
Harbormaster completed remote builds in B6714: Diff 9525.Feb 10 2022, 6:49 AM

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines
1 line

Diff 9526

View Options

web/chat/chat-input-bar.css

Loading...
View Options

web/theme.css

Loading...