fix up html + css while changing the unread theme
before:
after:
Details
Details
after:
click unread, no new functionality or changes should happen.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
chat thread list item menu markup
This title is kind of hard for me to make sense of.
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 196–198 ↗ | (On Diff #9575) | Aren't we losing this menu item styling logic? Would it hurt anything to keep things contained in an unordered list/list item? |
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 196–198 ↗ | (On Diff #9575) | No, there was only ever one item. There wasn't ever any _real_ design for this button. |
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 201 ↗ | (On Diff #9575) | should we avoid using a hard-coded hex value here? |
Comment Actions
Can you provide a before/after screenshot here? It's hard for me to review this without knowing what's being changed, and in the past we've had design regressions introduced in unrelated diffs so I'm a bit wary.
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 201 ↗ | (On Diff #9575) | Yeah, I didn't want to just randomly change the color value. I can continue to grab color values in another diff. |
Comment Actions
Looking at this one last time before landing I noticed the background color has changed in my diff.
I'm going to fix it before I land it.
Comment Actions
just double-checked master and feature branch and they're the same. The background color was changed in a different commit un-related to this one.
I take it back:
