Page MenuHomePhabricator
Differential D3184

[web] [refator] Chat thread list
ClosedPublic
Actions

Authored by • benschac on Feb 11 2022, 2:31 PM.
Tags
None
Referenced Files
F2156163: D3184.diff
Sun, Jun 30, 11:19 PM
Unknown Object (File)
Tue, Jun 18, 11:33 PM
Unknown Object (File)
Thu, Jun 13, 8:27 AM
Unknown Object (File)
Thu, Jun 13, 1:20 AM
Unknown Object (File)
Wed, Jun 12, 11:03 PM
Unknown Object (File)
Wed, Jun 12, 8:46 PM
Unknown Object (File)
May 18 2024, 4:31 AM
Unknown Object (File)
May 8 2024, 9:57 AM
View All 95 Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM1a3f76d0c9c3: [web] [refator] Chat thread list
Summary

destructure item a bit more. No new functionality.

Test Plan

make sure thread item still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 11 2022, 2:31 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 11 2022, 2:31 PM
Harbormaster completed remote builds in B6764: Diff 9585.Feb 11 2022, 2:35 PM
• benschac requested review of this revision.Feb 11 2022, 2:35 PM
atul accepted this revision.Feb 14 2022, 11:21 AM

[web] [refator] Chat thread list

High level feedback, but let's clean these titles up a bit...

Maybe something like:

"[web] [refactor] Destructure props.item in ChatThreadListItem"?

web/chat/chat-thread-list-item.react.js
34 ↗(On Diff #9585)

Wonder if keeping the threadID name could make things clearer to the reader?

This revision is now accepted and ready to land.Feb 14 2022, 11:21 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 14 2022, 11:21 AM
This revision now requires review to proceed.Feb 14 2022, 11:21 AM
ashoat accepted this revision.Feb 14 2022, 9:34 PM

Agree on thread titles. Please be more thoughtful about communication!

This revision is now accepted and ready to land.Feb 14 2022, 9:34 PM
• benschac updated this revision to Diff 9671.Feb 15 2022, 6:21 AM

address threadID comment in diff review

This revision was landed with ongoing or failed builds.Feb 15 2022, 6:25 AM
Closed by commit rCOMM1a3f76d0c9c3: [web] [refator] Chat thread list (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM1a3f76d0c9c3: [web] [refator] Chat thread list.
Harbormaster completed remote builds in B6832: Diff 9671.Feb 15 2022, 6:26 AM

Revision Contents
Changeset List

PathSize
web/
chat/
22 lines

Diff 9672

View Options

web/chat/chat-thread-list-item.react.js

Loading...