[web] [feat] add unread dot
ClosedPublic
Actions

Authored by • benschac on Feb 11 2022, 3:22 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMM167b315db3e1: [web] [feat] add unread dot

Summary

add unread dot per figma screen shot

Ignore title color, will fix in a follow up diff.

Test Plan

match figma

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

• benschac requested review of this revision.Feb 11 2022, 3:26 PM

The screenshot looks good! Minor nits inline

web/chat/chat-thread-list-item.react.js
82 ↗	(On Diff #9589)	We can just do: `let unreadDot;` Unless you wanted to be explicit about it for some reason?
84 ↗	(On Diff #9589)	Can we do something like this?
137 ↗	(On Diff #9589)	Does it make sense for the `dotContainer` to be inside the `colorContainer`? Might want to rename `colorContainer` to something more broad.

This revision is now accepted and ready to land.Feb 14 2022, 11:03 AM

This revision now requires review to proceed.Feb 14 2022, 11:03 AM

This revision is now accepted and ready to land.Feb 14 2022, 9:31 PM

web/chat/chat-thread-list-item.react.js
137 ↗	(On Diff #9589)	I still think this is right. It does. We need the container to keep its width while the unread dot isn't shown. At some point this will change to avatar container.