[web] [refactor] remove prop drill from LoginFirstModal and swap for context
AbandonedPublic
Actions

Authored by • benschac on Feb 16 2022, 4:34 PM.

Details

Reviewers

atul
ashoat

Summary

remove prop drill

Test Plan

Diff Detail

Repository

rCOMM Comm

Branch

modalthatsworking

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Feb 16 2022, 4:34 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 16 2022, 4:34 PM

• benschac added inline comments.Feb 16 2022, 4:37 PM

web/modals/account/log-in-first-modal.react.js
18	I don't think we need a `useCallback` here. setModal is wrapped in one in the context.

Harbormaster completed remote builds in B6893: Diff 9742.Feb 16 2022, 4:39 PM

• benschac requested review of this revision.Feb 16 2022, 4:39 PM

Please make the dependency graph show up by adding "Depends on: Dwhatever" to the diff summary, and then re-request review.

This revision now requires changes to proceed.Feb 22 2022, 6:18 AM

Closing in favor of squashed diff stack: https://phabricator.ashoat.com/D3271

Revision Contents
Changeset List

Path

Size

web/

calendar/

day.react.js

7 lines

entry.react.js

14 lines

modals/

account/

log-in-first-modal.react.js

54 lines

Diff 9742

View Options

web/calendar/day.react.js

View Options

web/calendar/entry.react.js

View Options

web/modals/account/log-in-first-modal.react.js

[web] [refactor] remove prop drill from LoginFirstModal and swap for contextAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9742

web/calendar/day.react.js

web/calendar/entry.react.js

web/modals/account/log-in-first-modal.react.js

[web] [refactor] remove prop drill from LoginFirstModal and swap for context
AbandonedPublic
Actions

Revision Contents
Changeset List