[web] [chore] add icon types to Icons component
ClosedPublic
Actions

Authored by • benschac on Feb 18 2022, 9:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 1:06 AM

	Unknown Object (File)
	Sun, Dec 29, 1:06 AM

	Unknown Object (File)
	Sun, Dec 29, 1:05 AM

	Unknown Object (File)
	Sun, Dec 29, 12:57 AM

	Unknown Object (File)
	Nov 8 2024, 12:41 PM

	Unknown Object (File)
	Nov 8 2024, 12:41 PM

	Unknown Object (File)
	Nov 8 2024, 12:40 PM

	Unknown Object (File)
	Nov 8 2024, 12:40 PM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMMbecd97298c43: [web] [chore] add icon types to Icons component

Summary

Type icon names, add auto-complete to icon component for better developer experience

Test Plan

flow shouldn't error out

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 18 2022, 9:15 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 18 2022, 9:15 AM

Harbormaster completed remote builds in B6924: Diff 9778.Feb 18 2022, 9:20 AM

• benschac requested review of this revision.Feb 18 2022, 9:20 AM

ashoat accepted this revision.Feb 21 2022, 10:34 PM

This revision is now accepted and ready to land.Feb 21 2022, 10:34 PM

Nice, thank you!!

Closed by commit rCOMMbecd97298c43: [web] [chore] add icon types to Icons component (authored by • benschac). · Explain WhyFeb 22 2022, 8:37 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMbecd97298c43: [web] [chore] add icon types to Icons component.

Revision Contents
Changeset List

Path

Size

web/

SWMansionIcon.react.js

42 lines

chat/

chat-thread-tab.react.js

4 lines

Diff 9819

View Options

web/SWMansionIcon.react.js