remove setModal in chat
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Please make the dependency graph show up by adding "Depends on: Dwhatever" to the diff summary, and then re-request review.
| web/chat/chat-message-list.react.js | ||
|---|---|---|
| 387 | Removing React.memo here is a very opinionated and potentially impactful change. You introduce this change here with zero discussion, in a diff that (seemingly) has nothing to do with this change. This change should absolutely be in its own diff. You would've probably saved time for everyone (yourself, Atul, and me) if you had squashed most of your modal diffs into one. But this change should absolutely be separated out into its own diff. | |
Comment Actions
Closing in favor of squashed diff stack: https://phabricator.ashoat.com/D3271
| web/chat/chat-message-list.react.js | ||
|---|---|---|
| 387 | We chatted about this IRL. I squashed this into one diff here: https://phabricator.ashoat.com/D3271 Going to re-introduce React.memo where they were removed. | |