[web] [refactor] replace/remove setModal in FilterPanel component with context
AbandonedPublic
Actions

Authored by • benschac on Feb 18 2022, 6:22 PM.

Details

Reviewers

atul
ashoat

Summary

remove prop drill from filter panel component

Test Plan

filter panel functionality should work as expected in calendar component

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2022, 6:29 PM

• benschac requested review of this revision.Feb 19 2022, 7:00 PM

Please make the dependency graph show up by adding "Depends on: Dwhatever" to the diff summary, and then re-request review.
Why did the build fail? You should never override the CI without comment like you did above. If the CI is experiencing a transient error that has no relation to your diff, it's always better to re-run arc diff than to override the CI. If there's no way around it, then you can request review, but ONLY if you leave a comment explaining to your reviewer why you are doing so.

web/calendar/filter-panel.react.js
365	See feedback in D3254 – you should absolutely never sneak changes that can cause perf regressions into unrelated diffs, like you're doing here. Please separate this out into its own diff. The less controversial parts of the stack probably should've been squashed into one, whereas these `React.memo` changes should've been squashed into another. Then we could have had two diffs, each with a concrete description / test plan.