[web] Show "leave thread" modal from thread menu
ClosedPublic
Actions

Authored by • jacek on Mar 4 2022, 5:42 AM.

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM9709f68244fd: [web] Show "leave thread" modal from thread menu

Summary

Add action on "Leave thread" item in thread menu. It displays modal with confirmation before leaving thread.

Test Plan

Select thread, that can be left (like some community thread) and select "Leave thread" from thread menu.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Mar 4 2022, 5:42 AM

Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 5:42 AM

Harbormaster completed remote builds in B7145: Diff 10070.Mar 4 2022, 5:48 AM

• jacek requested review of this revision.Mar 4 2022, 5:48 AM

• jacek added reviewers: • benschac, atul.Mar 4 2022, 8:13 AM

Accepting, but please address my comment before landing

web/chat/thread-menu.react.js
142–148 ↗	(On Diff #10070)	We have a couple of levels of indentation here, so it would be a good idea to define `onConfirm` function outside this callback as a separate callback - just to improve the readability.

This revision is now accepted and ready to land.Mar 4 2022, 10:32 AM

Moved onConfirm lambda into separate callback.

Harbormaster completed remote builds in B7182: Diff 10108.Mar 7 2022, 7:12 AM

Closed by commit rCOMM9709f68244fd: [web] Show "leave thread" modal from thread menu (authored by • jacek). · Explain WhyMar 9 2022, 7:20 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM9709f68244fd: [web] Show "leave thread" modal from thread menu.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-menu.react.js

42 lines

Diff 10215

View Options

web/chat/thread-menu.react.js

[web] Show "leave thread" modal from thread menuClosedPublicActions