Differential D3407

Revert "[web] [refactor] remove unneeded div in chat-thread-list component"
ClosedPublic
Actions

Authored by • benschac on Mar 11 2022, 10:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 9:00 AM

	Unknown Object (File)
	Fri, Nov 15, 9:00 AM

	Unknown Object (File)
	Sun, Nov 10, 12:10 AM

	Unknown Object (File)
	Sun, Nov 10, 12:10 AM

	Unknown Object (File)
	Fri, Nov 8, 7:42 AM

	Unknown Object (File)
	Tue, Nov 5, 1:03 AM

	Unknown Object (File)
	Sat, Nov 2, 2:33 AM

	Unknown Object (File)
	Sat, Nov 2, 2:32 AM

Subscribers

Details

Reviewers

Commits

rCOMM7d8e81f8dddf: Revert "[web] [refactor] remove unneeded div in chat-thread-list component"

Summary

This reverts commit 8de95514f0a0213981e4cb9f790bc3393c4c3930.

before:

Image 2022-03-11 at 1.36.53 PM.jpg (1×2 px, 160 KB)

after:

Image 2022-03-11 at 1.37.27 PM.jpg (998×1 px, 122 KB)

Test Plan

this broke web. The mark as read button is now showing when there isn't a hover over the chat thread item element.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 11 2022, 10:35 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 11 2022, 10:35 AM

• benschac edited the summary of this revision. (Show Details)Mar 11 2022, 10:37 AM

Harbormaster completed remote builds in B7308: Diff 10308.Mar 11 2022, 10:40 AM

• benschac requested review of this revision.Mar 11 2022, 10:40 AM

atul accepted this revision.Mar 11 2022, 12:34 PM

This revision is now accepted and ready to land.Mar 11 2022, 12:34 PM

Closed by commit rCOMM7d8e81f8dddf: Revert "[web] [refactor] remove unneeded div in chat-thread-list component" (authored by • benschac). · Explain WhyMar 11 2022, 12:48 PM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM7d8e81f8dddf: Revert "[web] [refactor] remove unneeded div in chat-thread-list component".

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-list-item-menu.react.js

8 lines

chat-thread-list.css

2 lines

Diff 10317

web/chat/chat-thread-list-item-menu.react.js

Loading...

web/chat/chat-thread-list.css

Loading...