[landing] Fix "fluid" `font-size` for `hero-content:sub_heading`
ClosedPublic
Actions

Authored by atul on Mar 15 2022, 12:34 PM.

Details

Reviewers

• benschac
tomek
ashoat

Commits

rCOMM1349fa4902f8: [landing] Fix "fluid" `font-size` for `hero-content:sub_heading`

Summary

Continues to look as expected. Maintains proportion with the cycling header now which seems like it's actually a slight improvement.

Test Plan

Here's how it looks:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 15 2022, 12:34 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 15 2022, 12:34 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 15 2022, 12:36 PM

Harbormaster failed remote builds in B7394: Diff 10407!

atul requested review of this revision.Mar 15 2022, 12:36 PM

atul edited the test plan for this revision. (Show Details)

atul retitled this revision from [landing] Fix "fluid" `font-size` for hero-content:sub_heading to [landing] Fix "fluid" `font-size` for `hero-content:sub_heading`.

ashoat accepted this revision.Mar 15 2022, 8:43 PM

ashoat added inline comments.

landing/hero-content.css
15 ↗	(On Diff #10407)	Assume this was determined in the same way as https://phabricator.ashoat.com/D3434#inline-20247 (Should that diff be connected with this stack in any way? And how about the stack D3432 is in?)