Page MenuHomePhabricator

[landing] Fix "fluid" `font-size`/`padding-bottom` for `info-block:title`
ClosedPublic

Authored by atul on Mar 15 2022, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 27 2024, 5:29 AM
Unknown Object (File)
Oct 27 2024, 5:29 AM
Unknown Object (File)
Oct 27 2024, 5:28 AM
Unknown Object (File)
Oct 27 2024, 5:27 AM
Unknown Object (File)
Oct 27 2024, 5:17 AM
Unknown Object (File)
Oct 6 2024, 9:41 AM
Unknown Object (File)
Sep 24 2024, 4:51 AM
Unknown Object (File)
Sep 17 2024, 2:58 PM

Details

Summary

Interpolate over values from width of 320px to 1850px

Test Plan

Continues to look as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Mar 15 2022, 1:07 PM
atul added inline comments.
landing/info-block.css
29 ↗(On Diff #10410)

Removed this on purpose

ashoat added inline comments.
landing/info-block.css
29 ↗(On Diff #10410)

Why was it there in the first place?

This revision is now accepted and ready to land.Mar 15 2022, 8:44 PM
atul marked an inline comment as done.Mar 15 2022, 9:05 PM
atul added inline comments.
landing/info-block.css
29 ↗(On Diff #10410)

These styles were copied from the generated CSS in Figma. I think the understanding was that the styles were to be be copied exactly and that this change in letter-spacing was intentional.

But, I’m almost positive given how minuscule the value is and how little of a difference it makes visually, that this was just an unintentional artifact (resulting from some accidental misclick or whatever) that snuck through.

This revision was landed with ongoing or failed builds.Mar 16 2022, 12:10 PM
This revision was automatically updated to reflect the committed changes.