Linear issue: https://linear.app/comm/issue/ENG-857/admin-sees-an-option-to-promote-user-to-an-admin-even-if-there-is-such
This update introduces additional condition, which disables "Make admin" (and "remove admin") options, when there is no "Admins" role in the thread.
Details
Details
Log in as admin (to have "change_role" permission) in mobile app. In community threads without admin role, the members menu doesn't contain "Make admin" item.
In "Genesis" thread (which contain "Admins" role, there is still an option to change admin permissions for user (e.g. downgrade Ashoat user role)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think this makes sense. It doesn't feel great to have this sort of logic in native (given I suspect we will need it in web as well), but I think we can handle "factoring it out" once we get to it on web.