Differential D3576

[native] [fix] ENG-949 update timestamp to lowercase
ClosedPublic
Actions

Authored by • benschac on Mar 30 2022, 2:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 10:52 PM

	Unknown Object (File)
	Sun, Nov 10, 12:12 AM

	Unknown Object (File)
	Sun, Nov 10, 12:12 AM

	Unknown Object (File)
	Sun, Nov 10, 12:06 AM

	Unknown Object (File)
	Tue, Nov 5, 1:24 AM

	Unknown Object (File)
	Oct 29 2024, 5:29 AM

	Unknown Object (File)
	Oct 29 2024, 5:29 AM

	Unknown Object (File)
	Oct 29 2024, 5:29 AM

Subscribers

Details

Reviewers

atul
• abosh
• jacek
tomek
ashoat

Commits

rCOMMcca39d8b963b: [native] [fix] ENG-949 update timestamp to lowercase

Summary

Image 2022-03-30 at 5.03.19 PM.jpg (876×700 px, 146 KB)

update timestamp to match web

web:

Image 2022-03-30 at 5.13.32 PM.jpg (872×1 px, 62 KB)

Test Plan

open simulator, make sure the timestamp is lowercase

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 30 2022, 2:04 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptMar 30 2022, 2:04 PM

Harbormaster completed remote builds in B7733: Diff 10847.Mar 30 2022, 2:10 PM

• benschac requested review of this revision.Mar 30 2022, 2:10 PM

• benschac edited the summary of this revision. (Show Details)Mar 30 2022, 2:13 PM

• benschac added reviewers: • abosh, • jacek, tomek.

Accepting under assumption that there was some discussion that this was the right decision to make. Didn't see anything here: https://linear.app/comm/issue/ENG-949/make-conversation-timestamp-lowercase-to-stay-consistent-with-web, so guessing I missed some conversation.

Adding @ashoat as blocking reviewer to double check.

This revision is now accepted and ready to land.Mar 30 2022, 7:19 PM

atul added a reviewer: ashoat.Mar 30 2022, 7:19 PM

This revision now requires review to proceed.Mar 30 2022, 7:19 PM

I'm okay with it because it matches the Figma. I'm not sure I agree with the Figma. But I don't strongly disagree. @atul, what do you think?

This revision is now accepted and ready to land.Mar 30 2022, 11:15 PM

Closed by commit rCOMMcca39d8b963b: [native] [fix] ENG-949 update timestamp to lowercase (authored by • benschac). · Explain WhyMar 31 2022, 6:54 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMcca39d8b963b: [native] [fix] ENG-949 update timestamp to lowercase.

But I don't strongly disagree. @atul, what do you think?

I prefer all caps (for both mobile and web), but don't feel that strongly about it.

Looks like FB Messenger goes with all caps, and iMessage goes with mixed case... so either way probably isn't going to make a difference lol

Revision Contents
Changeset List

Path

Size

native/

chat/

timestamp.react.js

6 lines

Diff 10886

native/chat/timestamp.react.js

Loading...