Paths

Table of Contentst

[landing] Remove `isDev` gate for "Launch app" icon in landing `Header`
ClosedPublic
Actions

Authored by atul on Apr 7 2022, 11:00 AM.

Tags

None

Referenced Files

	F3859588: D3656.diff
	Wed, Jan 22, 1:57 AM

	Unknown Object (File)
	Tue, Dec 31, 1:17 PM

	Unknown Object (File)
	Tue, Dec 31, 1:17 PM

	Unknown Object (File)
	Tue, Dec 31, 1:17 PM

	Unknown Object (File)
	Tue, Dec 31, 1:17 PM

	Unknown Object (File)
	Tue, Dec 31, 1:10 PM

	Unknown Object (File)
	Dec 20 2024, 2:46 AM

	Unknown Object (File)
	Dec 2 2024, 4:31 PM

Subscribers

Details

Reviewers

ashoat
tomek

Commits

rCOMM307df3a5a399: [landing] Remove `isDev` gate for "Launch app" icon in landing `Header`

Summary

We were gating the icon behind an isDev flag until https://web.comm.app was ready to go, and now it is.

Test Plan

Clicked the button and it took me to https://web.comm.app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 7 2022, 11:00 AM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 7 2022, 11:00 AM

Harbormaster completed remote builds in B7986: Diff 11191.Apr 7 2022, 11:04 AM

atul requested review of this revision.Apr 7 2022, 11:04 AM

atul added a reviewer: tomek.Apr 8 2022, 6:34 AM

ashoat accepted this revision.Apr 8 2022, 8:08 AM

This revision is now accepted and ready to land.Apr 8 2022, 8:08 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 8 2022, 8:20 AM

Closed by commit rCOMM307df3a5a399: [landing] Remove `isDev` gate for "Launch app" icon in landing `Header` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM307df3a5a399: [landing] Remove `isDev` gate for "Launch app" icon in landing `Header`.

Harbormaster failed remote builds in B8032: Diff 11245!Apr 8 2022, 8:24 AM

Revision Contents
Changeset List

Path

Size

landing/

header.react.js

18 lines

Diff 11246

View Options

[landing] Remove `isDev` gate for "Launch app" icon in landing `Header`ClosedPublicActions