chore, move onClick button type to lib and export
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- benjamin/eng-1019-update-button-types
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/core.js | ||
|---|---|---|
| 5 | Not sure if we should name this something like, ButtonClick | |
Comment Actions
Not clear to me that this is helping at all. The extra indirection here isn't worth the DRY, in my opinion. I would favor abandoning this
| lib/types/core.js | ||
|---|---|---|
| 5 | This is clearly a bad name, it's way too generic... OnClick in lib/types/core.js would appear to be a "core" type that covers every single on-click callback | |
Comment Actions
Fair enough. I thought it would be helpful since we're using the same onClick handler. Not married to it. Happy to abandon.