Page MenuHomePhabricator
Differential D3847

[keyserver] Get rid of container_name for Node in docker-compose.yml
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 7:46 PM.
Tags
None
Referenced Files
F5904360: D3847.id11897.diff
Thu, Apr 17, 1:36 PM
F5879349: D3847.id.diff
Thu, Apr 17, 1:52 AM
F5877140: D3847.id12000.diff
Thu, Apr 17, 1:06 AM
Unknown Object (File)
Wed, Apr 16, 10:14 AM
Unknown Object (File)
Tue, Apr 8, 6:56 PM
Unknown Object (File)
Tue, Apr 8, 8:18 AM
Unknown Object (File)
Tue, Apr 8, 8:03 AM
Unknown Object (File)
Tue, Apr 8, 7:48 AM
View All Files
Subscribers
• abosh
• adrian
atul
• jim
• karol

Details

Reviewers
tomek
• jim
Commits
rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml
Summary

From docs:

Because Docker container names must be unique, you cannot scale a service beyond 1 container if you have specified a custom name.

@jimpo also highlighted this in his review of D3713.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2022, 7:46 PM
Herald added subscribers: • abosh, • karol, atul, • adrian. · View Herald TranscriptApr 25 2022, 7:46 PM
ashoat added a child revision: D3848: [keyserver] Add rsync to Dockerfile.Apr 25 2022, 7:47 PM
Harbormaster completed remote builds in B8535: Diff 11897.Apr 25 2022, 7:51 PM
ashoat requested review of this revision.Apr 25 2022, 7:51 PM
tomek accepted this revision.Apr 26 2022, 9:36 AM
This revision is now accepted and ready to land.Apr 26 2022, 9:36 AM
Closed by commit rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml (authored by ashoat). · Explain WhyApr 27 2022, 11:40 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml.
tomek mentioned this in D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.May 9 2022, 7:14 AM
• max mentioned this in D4014: [services] Remove `container_name` from docker-compose file.May 12 2022, 4:59 AM
• max mentioned this in rCOMM53b692443067: [services] Remove `container_name` from docker-compose file.May 13 2022, 5:27 AM

Revision Contents
Changeset List

PathSize
keyserver/
1 line

Diff 12000

View Options

keyserver/docker-compose.yml

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall