Paths

Table of Contentst

-
keyserver/src/socket/
-
src/
-
socket/
-
redis.js

Differential D3870

[keyserver] Defer Redis publisher construction until actually used
ClosedPublic
Actions

Authored by ashoat on Apr 27 2022, 8:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 27, 10:05 AM

	Unknown Object (File)
	Sun, Mar 23, 4:02 PM

	Unknown Object (File)
	Mar 4 2025, 3:31 PM

	Unknown Object (File)
	Mar 2 2025, 3:19 AM

	Unknown Object (File)
	Feb 14 2025, 6:24 PM

	Unknown Object (File)
	Feb 6 2025, 1:28 AM

	Unknown Object (File)
	Feb 6 2025, 1:28 AM

	Unknown Object (File)
	Feb 3 2025, 3:07 PM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM188caefbb4c4: [keyserver] Defer Redis publisher construction until actually used

Summary

The current behavior means that anything that inadvertedly imports redis.js (update-geoip.js, for instance) will crash if it can't reach Redis.

This diff makes it so RedisPublisher only tries to connect to Redis on the first call to sendMessage().

Test Plan

Make sure yarn update-geoip works from a Docker buildscript

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 27 2022, 8:13 PM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptApr 27 2022, 8:13 PM

ashoat added a child revision: D3871: [keyserver] Dockerfile for Node keyserver.Apr 27 2022, 8:17 PM

Harbormaster completed remote builds in B8635: Diff 12025.Apr 27 2022, 8:18 PM

ashoat requested review of this revision.Apr 27 2022, 8:18 PM

tomek accepted this revision.Apr 28 2022, 1:45 AM

This revision is now accepted and ready to land.Apr 28 2022, 1:45 AM

Closed by commit rCOMM188caefbb4c4: [keyserver] Defer Redis publisher construction until actually used (authored by ashoat). · Explain WhyApr 28 2022, 11:27 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM188caefbb4c4: [keyserver] Defer Redis publisher construction until actually used.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

11 lines

Diff 12055

keyserver/src/socket/redis.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines		if (!hasNonce) {
	return (			return (
	<div className={css.wrapper}>			<div className={css.wrapper}>
	<div className={css.walletDisplay}>			<div className={css.walletDisplay}>
	<span className={css.walletDisplayText}>Wallet Connected:</span>			<span className={css.walletDisplayText}>Wallet Connected:</span>
	<ConnectButton />			<ConnectButton />
	</div>			</div>
	<p>{siweMessageSigningExplanationStatements[0]}</p>			<p>{siweMessageSigningExplanationStatements[0]}</p>
	<p>{siweMessageSigningExplanationStatements[1]}</p>			<p>{siweMessageSigningExplanationStatements[1]}</p>
				<p>
				By signing up, you agree to our{' '}
				<a href="https://comm.app/terms">Terms of Use</a> &{' '}
				<a href="https://comm.app/privacy">Privacy Policy</a>.
				</p>
	<div className={css.button} onClick={onClick}>			<div className={css.button} onClick={onClick}>
	Sign in			Sign in
	</div>			</div>
	</div>			</div>
	);			);
	}			}
	}			}

	Show All 22 Lines