Page MenuHomePhabricator

[keyserver] Shift Redis Docker Compose config from ports to expose
ClosedPublic

Authored by ashoat on May 2 2022, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 9:07 AM
Unknown Object (File)
Fri, Nov 15, 9:07 AM
Unknown Object (File)
Fri, Nov 15, 6:10 AM
Unknown Object (File)
Thu, Nov 14, 9:07 AM
Unknown Object (File)
Wed, Nov 13, 6:55 AM
Unknown Object (File)
Thu, Nov 7, 5:54 PM
Unknown Object (File)
Sun, Nov 3, 3:18 PM
Unknown Object (File)
Oct 8 2024, 12:45 AM

Details

Summary

Based on this StackOverflow, the only difference between ports and expose is that ports exposes the port on the host machine, whereas expose only exposes it to other services in the same Docker Compose config.

Since we intend for this Docker Compose config to be publicly deployable, I think it would be good to have a bit stronger security here and avoid exposing the Redis port publicly on the host machine.

It may make debugging a bit more complicated... we could consider creating a separate docker-compose.yml for dev, but to be honest I don't think we even need to run dev in Docker (we're aiming to use Nix for that) so it's probably not a big deal.

Test Plan

Run docker-compose up --build and make sure Node can still connect to Redis

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable