[keyserver] Update Node Docker Compose config to always restart
ClosedPublic
Actions

Authored by ashoat on May 2 2022, 7:21 AM.

Details

Reviewers

• jim
varun

Commits

rCOMM09b3e03d5949: [keyserver] Update Node Docker Compose config to always restart

Summary

MySQL takes a while to start up, and Node will crash if MySQL (or Redis) doesn't respond.

We should probably make it so Node doesn't crash if it can't reach a service, and instead keeps retrying. But I actually think it's good to auto-restart the Node server either way here.

Test Plan

Run docker-compose up --build and make sure Node keeps restarting when it fails to connect to MySQL

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 2 2022, 7:21 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptMay 2 2022, 7:21 AM

Harbormaster completed remote builds in B8709: Diff 12130.May 2 2022, 7:32 AM

ashoat requested review of this revision.May 2 2022, 7:32 AM

ashoat added a reviewer: varun.May 2 2022, 8:10 AM

varun accepted this revision.May 2 2022, 12:01 PM

This revision is now accepted and ready to land.May 2 2022, 12:01 PM

Closed by commit rCOMM09b3e03d5949: [keyserver] Update Node Docker Compose config to always restart (authored by ashoat). · Explain WhyMay 3 2022, 9:27 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM09b3e03d5949: [keyserver] Update Node Docker Compose config to always restart.

Revision Contents
Changeset List

Path

Size

keyserver/

docker-compose.yml

1 line

Diff 12172

View Options

keyserver/docker-compose.yml

[keyserver] Update Node Docker Compose config to always restartClosedPublicActions