Paths

Table of Contentst

[web] Remove unnecessary `form_footer` div and corresponding styles
ClosedPublic
Actions

Authored by atul on May 5 2022, 6:27 AM.

Tags

None

Referenced Files

	F3392681: D3926.diff
	Sat, Nov 30, 9:47 AM

	Unknown Object (File)
	Wed, Nov 27, 3:28 PM

	Unknown Object (File)
	Wed, Nov 27, 1:33 PM

	Unknown Object (File)
	Mon, Nov 11, 7:32 PM

	Unknown Object (File)
	Mon, Nov 11, 7:26 PM

	Unknown Object (File)
	Mon, Nov 11, 2:59 PM

	Unknown Object (File)
	Mon, Nov 11, 2:42 AM

	Unknown Object (File)
	Sat, Nov 9, 3:24 PM

Subscribers

Details

Reviewers

ashoat
tomek

Commits

rCOMM8951a8faa85e: [web] Remove unnecessary `form_footer` div and corresponding styles

Summary

There's no need for this div. We can achieve the same thing with just the modal_form_error div.

Test Plan

Looks as expected:

Screen Shot 2022-05-05 at 9.26.22 AM.png (1×712 px, 76 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 5 2022, 6:27 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 6:27 AM

atul edited the test plan for this revision. (Show Details)May 5 2022, 6:27 AM

Harbormaster completed remote builds in B8807: Diff 12273.May 5 2022, 6:31 AM

atul requested review of this revision.May 5 2022, 6:31 AM

ashoat accepted this revision.May 5 2022, 8:54 AM

This revision is now accepted and ready to land.May 5 2022, 8:54 AM

Closed by commit rCOMM8951a8faa85e: [web] Remove unnecessary `form_footer` div and corresponding styles (authored by atul). · Explain WhyMay 5 2022, 9:13 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8951a8faa85e: [web] Remove unnecessary `form_footer` div and corresponding styles.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.css

11 lines

thread-settings-modal.react.js

4 lines

Diff 12291

View Options

web/modals/threads/thread-settings-modal.css