Page MenuHomePhabricator
Differential D3975

[keyserver] Update URL facts function to use dynamic loading mechanism
ClosedPublic
Actions

Authored by ashoat on May 9 2022, 3:39 PM.
Tags
None
Referenced Files
F2180144: D3975.diff
Wed, Jul 3, 2:31 PM
Unknown Object (File)
Tue, Jul 2, 12:54 PM
Unknown Object (File)
Tue, Jul 2, 7:07 AM
Unknown Object (File)
Tue, Jul 2, 2:28 AM
Unknown Object (File)
Sat, Jun 29, 8:06 PM
Unknown Object (File)
Fri, Jun 21, 8:45 PM
Unknown Object (File)
Fri, Jun 21, 8:45 PM
Unknown Object (File)
Fri, Jun 21, 8:45 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
atul
tomek
Commits
rCOMMedc26e3b800d: [keyserver] Update URL facts function to use dynamic loading mechanism
Summary

The previous diff introduced this mechanism, but did not actually update callsites.

The overall goal is to make these files optional. The next diff will update the types to be optional.

Depends on D3974

Test Plan

Make sure I can still use the keyserver

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 9 2022, 3:39 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 9 2022, 3:39 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 9 2022, 3:39 PM
Harbormaster failed remote builds in B8942: Diff 12452!
ashoat updated this revision to Diff 12454.May 9 2022, 3:46 PM

Rebase to fix Buildkite

ashoat added a child revision: D3976: [keyserver] Update report and upload URLs to use web.comm.app.May 9 2022, 3:46 PM
Harbormaster completed remote builds in B8944: Diff 12454.May 9 2022, 3:54 PM
ashoat requested review of this revision.May 9 2022, 3:54 PM
tomek accepted this revision.May 10 2022, 1:25 AM
This revision is now accepted and ready to land.May 10 2022, 1:25 AM
ashoat added inline comments.May 10 2022, 5:50 AM
keyserver/src/utils/urls.js
58 ↗(On Diff #12454)

This probably should've been in a following diff, my bad. Will just land as-is this time

Closed by commit rCOMMedc26e3b800d: [keyserver] Update URL facts function to use dynamic loading mechanism (authored by ashoat). · Explain WhyMay 10 2022, 6:01 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMedc26e3b800d: [keyserver] Update URL facts function to use dynamic loading mechanism.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
32 lines
utils/
20 lines

Diff 12498

View Options

keyserver/src/database/migrations.js

Loading...
View Options

keyserver/src/utils/urls.js

Loading...