Page MenuHomePhabricator
Differential D4002

[services] Fix reactor status holder
ClosedPublic
Actions

Authored by • karol on May 11 2022, 7:37 AM.
Tags
None
Referenced Files
F5302874: D4002.diff
Tue, Apr 8, 3:49 AM
Unknown Object (File)
Wed, Apr 2, 2:43 AM
Unknown Object (File)
Wed, Mar 19, 9:35 PM
Unknown Object (File)
Wed, Mar 19, 3:20 AM
Unknown Object (File)
Mon, Mar 17, 2:10 PM
Unknown Object (File)
Wed, Mar 12, 5:03 PM
Unknown Object (File)
Mar 4 2025, 4:58 AM
Unknown Object (File)
Feb 16 2025, 6:35 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMM436227742fda: [services] Fix reactor status holder
Summary

I noticed that there are still ReactorUtility files and since we agreed on the name ReactorStatusHolder, it should also be applied everywhere in the code as well as in the files' names.

Test Plan

Services should build normally

cd services
yarn test-blob-service-dev-mode
yarn test-backup-service-dev-mode

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
12 lines
12 lines
11 lines
blob/
src/
Reactors/
lib/
src/
2 lines
client-base-reactors/
28 lines
30 lines
26 lines
server-base-reactors/
16 lines
26 lines
24 lines
lib/
src/
backup/
src/
Reactors/

Diff 12575

View Options

services/backup/src/Reactors/ReactorStatusHolder.h

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/server/PullBackupReactor.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines
View Options

services/blob/src/Reactors/ReactorStatusHolder.h

Loading...
View Options

services/lib/src/BaseReactor.h

Loading...
View Options

services/lib/src/ReactorStatusHolder.h

Loading...
View Options

services/lib/src/ReactorUtility.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...