[services] Extract glog installation from folly installation
ClosedPublic
Actions

Authored by • max on May 16 2022, 6:10 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMMf1b0af3fbd23: [services] Extract glog installation from folly installation

Summary

At the moment we have glog installation inside the Folly installation bash script in services/base-image/docker/install_folly.sh

Starting from D3969 we are using the glog as our own services dependency and we must extract it to the separate installation script, as mentioned in
the D3969 comments.

Linear task: ENG-1144

Test Plan

Run yarn build-base-image successfully bult services base image.

Diff Detail

Repository

rCOMM Comm

Branch

extend-glog-from-folly

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.May 16 2022, 6:10 AM

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 16 2022, 6:10 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 16 2022, 6:11 AM

Harbormaster failed remote builds in B9157: Diff 12734!

• max edited the summary of this revision. (Show Details)May 16 2022, 6:11 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek.

Add execute bit to the created bash script.

Harbormaster completed remote builds in B9158: Diff 12735.May 16 2022, 6:20 AM

• max requested review of this revision.May 16 2022, 6:20 AM

tomek accepted this revision.May 16 2022, 9:56 AM

tomek added 1 blocking reviewer(s): • karol.

Note @geekbrother's question on Linear here

In D4054#114032, @ashoat wrote:

Note @geekbrother's question on Linear here

Following the comment about C++ dependencies versions, I've created ENG-1144 task to track this in the future.
Passing to @karol-bisztyga for a review.

• karol accepted this revision.May 20 2022, 1:52 AM

This revision is now accepted and ready to land.May 20 2022, 1:52 AM

Rebase on master.

This revision was landed with ongoing or failed builds.May 20 2022, 4:15 AM

Closed by commit rCOMMf1b0af3fbd23: [services] Extract glog installation from folly installation (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMf1b0af3fbd23: [services] Extract glog installation from folly installation.

Harbormaster completed remote builds in B9362: Diff 12974.May 20 2022, 4:26 AM